Skip to content

Commit

Permalink
Support cookie w/ only Expires attribute in MockHttpServletResponse
Browse files Browse the repository at this point in the history
Prior to this commit, MockHttpServletResponse only included the Expires
attribute in the generated Cookie header if the Max-Age attribute had
also been set.

This commit supports including the Expires attribute in the generated
Cookie Header even when the Max-Age attribute has not been set.

Closes gh-26558
  • Loading branch information
Koos Gadellaa authored and sbrannen committed Feb 17, 2021
1 parent e17ca9a commit 40661d6
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,10 @@ private String getCookieHeader(Cookie cookie) {
buf.append("; Domain=").append(cookie.getDomain());
}
int maxAge = cookie.getMaxAge();
ZonedDateTime expires = (cookie instanceof MockCookie ? ((MockCookie) cookie).getExpires() : null);
if (maxAge >= 0) {
buf.append("; Max-Age=").append(maxAge);
buf.append("; Expires=");
ZonedDateTime expires = (cookie instanceof MockCookie ? ((MockCookie) cookie).getExpires() : null);
if (expires != null) {
buf.append(expires.format(DateTimeFormatter.RFC_1123_DATE_TIME));
}
Expand All @@ -391,6 +391,11 @@ private String getCookieHeader(Cookie cookie) {
buf.append(headers.getFirst(HttpHeaders.EXPIRES));
}
}
else if (expires != null) {
buf.append("; Expires=");
buf.append(expires.format(DateTimeFormatter.RFC_1123_DATE_TIME));
}


if (cookie.getSecure()) {
buf.append("; Secure");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,17 @@ void addCookieHeaderWithZeroExpiresAttribute() {
assertThat(header).startsWith("SESSION=123; Path=/; Max-Age=100; Expires=");
}

/**
* @since 5.1.12
*/
@Test
void addCookieHeaderWithOnlyExpiresAttribute() {
String cookieValue = "SESSION=123; Path=/; Expires=Tue, 8 Oct 2019 19:50:00 GMT";
response.addHeader(SET_COOKIE, cookieValue);
assertNumCookies(1);
assertThat(response.getHeader(SET_COOKIE)).isEqualTo(cookieValue);
}

@Test
void addCookie() {
MockCookie mockCookie = new MockCookie("SESSION", "123");
Expand Down

0 comments on commit 40661d6

Please sign in to comment.