Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement let, pipeline in $lookup #4272

Closed
wants to merge 3 commits into from
Closed

Implement let, pipeline in $lookup #4272

wants to merge 3 commits into from

Conversation

sangyongchoi
Copy link
Contributor

Hi, i am spring data mongo user.
I found that 'let' and 'pipeline' are not supported.
So I implemented it.
Could you please review this pr?
Thank you 😄

related issue

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2023
@christophstrobl
Copy link
Member

Thank you @sangyongchoi for bringing this topic up and taking the time to craft the PR! Care to add yourself as an author to the modified files?

@christophstrobl christophstrobl added status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 16, 2023
@christophstrobl christophstrobl linked an issue Jan 16, 2023 that may be closed by this pull request
Add support for $lookup with let/pipeline form to aggregation [DATAMONGO-2467] #3322
Closed
@christophstrobl christophstrobl self-assigned this Jan 16, 2023
@sangyongchoi
Copy link
Contributor Author

@christophstrobl I have already added to the author.
Is there any additional place to fill out?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 16, 2023
@christophstrobl
Copy link
Member

thanks, seems I must have overlooked it. We'll take it from here :)

christophstrobl pushed a commit that referenced this pull request Feb 16, 2023
@sangyongchoi @christophstrobl
Add support for 'let' and 'pipeline' in $lookup
83923e0 
This commit introduces let and pipline to the Lookup aggregation stage.

Closes: #3322
Original Pull Request: #4272
christophstrobl added a commit that referenced this pull request Feb 16, 2023
@christophstrobl
Polishing.
4d050f5 
Reuse Let from VariableOperators.
Limit API exposure and favor builders.
Update nullability constraints and assertions.
Update integration tests.
Add unit tests.

Original Pull Request: #4272
@christophstrobl
Copy link
Member

@sangyongchoi thank you very much for your contribution! Merged to main development line via 83923e0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@christophstrobl christophstrobl

Labels
status: feedback-provided Feedback has been provided type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for $lookup with let/pipeline form to aggregation [DATAMONGO-2467]
3 participants
@sangyongchoi @christophstrobl @spring-projects-issues