Do not rely on ManagedType by default #3275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManagedType may be erased type if the attribute is declared as generic, take Hibernate 6.x for example, exception is thrown like: ``` java.lang.IllegalArgumentException: Unable to locate Attribute with the given name [name] on this ManagedType [java.lang.Object] at org.hibernate.metamodel.model.domain.AbstractManagedType.checkNotNull(AbstractManagedType.java:225) ~[hibernate-core-6.3.1.Final.jar:6.3.1.Final] at org.hibernate.metamodel.model.domain.AbstractManagedType.getAttribute(AbstractManagedType.java:148) ~[hibernate-core-6.3.1.Final.jar:6.3.1.Final] at org.hibernate.metamodel.model.domain.AbstractManagedType.getAttribute(AbstractManagedType.java:43) ~[hibernate-core-6.3.1.Final.jar:6.3.1.Final] at org.springframework.data.jpa.repository.query.QueryUtils.requiresOuterJoin(QueryUtils.java:836) ~[spring-data-jpa-3.2.0.jar:3.2.0] ``` Fix spring-projectsGH-3274
Comment on lines
+825
to
+846
| if (model.getClass().getName().startsWith("org.eclipse.persistence")) { | ||
| // required for EclipseLink: we try to avoid using from.get as EclipseLink produces an inner join | ||
| // regardless of which join operation is specified next | ||
| // see: https://bugs.eclipse.org/bugs/show_bug.cgi?id=413892 | ||
| // still occurs as of 2.7 | ||
| ManagedType<?> managedType = null; | ||
| if (model instanceof ManagedType) { | ||
| managedType = (ManagedType<?>) model; | ||
| } else if (model instanceof SingularAttribute | ||
| && ((SingularAttribute<?, ?>) model).getType() instanceof ManagedType) { | ||
| managedType = (ManagedType<?>) ((SingularAttribute<?, ?>) model).getType(); | ||
| } | ||
| if (managedType != null) { | ||
| propertyPathModel = (Bindable<?>) managedType.getAttribute(segment); | ||
| } else { | ||
| propertyPathModel = from.get(segment).getModel(); | ||
| } | ||
| } else { | ||
| // ManagedType may be erased type for some vendor if the attribute is declared as generic | ||
| // see: https://hibernate.atlassian.net/browse/HHH-16144 | ||
| // see: https://github.com/hibernate/hibernate-orm/pull/7630 | ||
| // see: https://github.com/jakartaee/persistence/issues/562 |
There was a problem hiding this comment.
I'm curious if we could hide the vendor specifics behind eg. the PersistenceProvider so we can encapsulate different behaviours when getting hold of the attribute .
I'm thinking of something that would allow us to do something like the following:
Bindable<?> propertyPathModel = PersistenceProvider.segmentResolver(from).resolve(segment);Having PersistenceProvider implement a let's call it PathSegmentResolver defaulting to from.get(segment).getModel(), we could move the eclipselink specific requirements with all the type checks to the ECLIPSELINK implementation.
There was a problem hiding this comment.
How to resolve PersistenceProvider in method QueryUtils::requiresOuterJoin?
mp911de
reviewed
Jan 10, 2024
| // ManagedType may be erased type for some vendor if the attribute is declared as generic | ||
| // see: https://hibernate.atlassian.net/browse/HHH-16144 | ||
| // see: https://github.com/hibernate/hibernate-orm/pull/7630 | ||
| // see: https://github.com/jakartaee/persistence/issues/562 | ||
| propertyPathModel = from.get(segment).getModel(); |
There was a problem hiding this comment.
from.get("parent").getModel() returns the erased type instead of the correct one inferred from type parameters.
|
This isn't a working fix, it just adds some additional complexity that happens to work by accident and not by intent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManagedType may be erased type if the attribute is declared as generic, take Hibernate 6.x for example, exception is thrown like:
Fix GH-3274