Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Propagation via W3C and B3 for OTel and Brave #32487

Conversation

marcingrzejszczak
Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Sep 23, 2022

Rationale

In order to provide the users with the basic tracing observability story we need the following, additional features

  • W3C propagation type as the default propagation option (there would be 2 options, W3C and B3)

Conditionals

  • If Micrometer Tracing IS NOT on the classpath
    • For Brave
      • [Context-Propagation] We will setup Brave B3 Propagation as default (there's no W3C support out of the box in Brave)
    • For OTel
      • [Context-Propagation] We will setup W3C Propagation without Baggage
      • [Context-Propagation] We will setup B3 Propagation without Baggage when B3 propagation property turned on
  • If Micrometer Tracing IS on the classpath
    • For Brave
    • For OTel:
      • [Context-Propagation] We will setup W3C Propagation without Baggage
      • [Context-Propagation] We will setup B3 Propagation without Baggage when B3 propagation property turned on

superseeds #32214
split from #32480

@marcingrzejszczak marcingrzejszczak changed the title Context propagation Context Propagation via W3C and B3 for OTel and Brave Sep 23, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 23, 2022
@wilkinsona
Copy link
Member

I got confused by the separation of the 3 PRs and processed this all in #32480 in the end. Sorry.

@wilkinsona wilkinsona closed this Sep 27, 2022
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants