Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open DataSourcePublicMetrics for easy extension (#10288) #10289

Closed
wants to merge 2 commits into from
Closed

open DataSourcePublicMetrics for easy extension (#10288) #10289

wants to merge 2 commits into from

Conversation

mduesterhoeft
Copy link

@mduesterhoeft mduesterhoeft commented Sep 14, 2017 •
edited
Loading

addresses #10289

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 14, 2017
@wilkinsona wilkinsona mentioned this pull request Sep 14, 2017
Closed
@wilkinsona
Copy link
Member

Thanks for opening your first Spring Boot pull request.

DataSourcePublicMetrics is going to be removed in 2.0 as part of the move to Micrometer-based metrics. I think we should let the dust settle on that a bit and then see what, if anything, needs to be done to meet this requirement. It may require nothing, some changes in Boot, some changes in Micrometer, or changes in Boot and Micrometer.

@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Sep 14, 2017
@mduesterhoeft
Copy link
Author

Interesting news - thanks.

@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: on-hold We can't start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mduesterhoeft @wilkinsona @philwebb @spring-projects-issues