Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
@SafeVarargs
to methods inChunk
andCompositeItemWriter
that take a generic varargs parameter but don't perform unsafe operations on them. This prevents false positive warnings in the users' code when they use these methods.In the constructor of
Chunk
with the generic varargs parameter, I've replacedArrays.stream(items).toList()
withArrays.asList(items)
. Both work fine regarding varargs safety in practice but the latter is explicitly annotated with@SafeVarargs
itself, whileArrays.stream
does not explicitly say that it works fine with an array of typeObject[]
in every case. UsingArray.asList
also saves one copy of the array, which is not needed as the array will be copied later anyway.