Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMLC - null in Monitor Thread Name #1433

Closed
garyrussell opened this issue Mar 15, 2022 · 0 comments · Fixed by #1435
Closed

DMLC - null in Monitor Thread Name #1433

garyrussell opened this issue Mar 15, 2022 · 0 comments · Fixed by #1435
Labels
backport:2.3.x (obsolete) backport:2.4.x (obsolete) type: bug
Milestone
3.0.0-M2

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Mar 15, 2022 •
edited
Loading

We are using getBean() instead of getListenerId().

Work around is to manually set a scheduler or copy the listener id into the bean name property.

https://stackoverflow.com/questions/71468360/which-component-is-creating-null-consumermonitor-threads/71483827#71483827
@garyrussell garyrussell added this to the 3.0.0-M2 milestone Mar 15, 2022
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Mar 15, 2022
@garyrussell
spring-projectsGH-1433: Fix DMLC MonitorThreadName
274d377 
Resolves spring-projects#1433

Used `beanName` instead of `listenerId` (which falls back to `beanName` if `null`).
Containers for annotations are not beans per se.

**cherry-pick to 2.4.x, 2.3.x**
@garyrussell garyrussell mentioned this issue Mar 15, 2022
Merged
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Mar 15, 2022
@garyrussell
spring-projectsGH-1433: Fix DMLC Monitor Thread Name
63d0f27 
Resolves spring-projects#1433

Used `beanName` instead of `listenerId` (which falls back to `beanName` if `null`).
Containers for annotations are not beans per se.

**cherry-pick to 2.4.x, 2.3.x**
artembilan pushed a commit that referenced this issue Mar 15, 2022
@garyrussell @artembilan
GH-1433: Fix DMLC Monitor Thread Name
0ccfcbe 
Resolves #1433

Used `beanName` instead of `listenerId` (which falls back to `beanName` if `null`).
Containers for annotations are not beans per se.

**cherry-pick to 2.4.x, 2.3.x**
artembilan pushed a commit that referenced this issue Mar 15, 2022
@garyrussell @artembilan
GH-1433: Fix DMLC Monitor Thread Name
6df5edd 
Resolves #1433

Used `beanName` instead of `listenerId` (which falls back to `beanName` if `null`).
Containers for annotations are not beans per se.

**cherry-pick to 2.4.x, 2.3.x**
artembilan pushed a commit that referenced this issue Mar 15, 2022
@garyrussell @artembilan
GH-1433: Fix DMLC Monitor Thread Name
46dfe31 
Resolves #1433

Used `beanName` instead of `listenerId` (which falls back to `beanName` if `null`).
Containers for annotations are not beans per se.

**cherry-pick to 2.4.x, 2.3.x**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport:2.3.x (obsolete) backport:2.4.x (obsolete) type: bug
Projects
None yet
Milestone
3.0.0-M2
Development

Successfully merging a pull request may close this issue.

GH-1433: Fix DMLC Monitor Thread Name garyrussell/spring-amqp
1 participant
@garyrussell