Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation as KafkaListener just works #1088

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Update documentation as KafkaListener just works #1088

merged 1 commit into from
Sep 7, 2018

Conversation

timtebeek
Copy link
Contributor

In contrast to earlier reports in #1001 it just seems to work in a sample project of mine:
https://github.com/timtebeek/sleuth-kafkalistener :)

@marcingrzejszczak
Copy link
Contributor

:D I love such pull requests

@marcingrzejszczak marcingrzejszczak added this to the 2.1.0.M1 milestone Sep 7, 2018
@marcingrzejszczak
Copy link
Contributor

fixes #1001

@marcingrzejszczak marcingrzejszczak merged commit 655c3a5 into spring-cloud:master Sep 7, 2018
@timtebeek timtebeek deleted the patch-2 branch September 7, 2018 12:36
@marcingrzejszczak marcingrzejszczak mentioned this pull request Sep 7, 2018
Closed
@timtebeek
Copy link
Contributor Author

Glad to "contribute" & keep up the good work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.1.0.M1
Development

Successfully merging this pull request may close these issues.
2 participants
@timtebeek @marcingrzejszczak