Remove function and use PropertyResolver #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantherdd
reviewed
Jan 22, 2024
...ain/java/org/springframework/cloud/netflix/eureka/config/EurekaConfigServerBootstrapper.java
Outdated
Show resolved
Hide resolved
This relates to spring-cloud/spring-cloud-config#2375 And reverts part of spring-cloud#4175
4c0f56d to
788f07b
Compare
pantherdd
reviewed
Jan 23, 2024
|
|
||
| public static Boolean getDiscoveryEnabled(BootstrapContext bootstrapContext) { |
There was a problem hiding this comment.
Unnecessary auto-boxing to Boolean (and I now realized, that's why this implementation has a method named get* instead of is*).
ryanjbaxter
added a commit
that referenced
this pull request
Jan 24, 2024
This relates to spring-cloud/spring-cloud-config#2375 And reverts part of #4175 Co-authored-by: Ryan Baxter <524254+ryanjbaxter@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to spring-cloud/spring-cloud-config#2375
And reverts part of #4175