Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Default Values in Eureka Appendix Documentation #4294

Closed
555cider opened this issue Jul 22, 2024 · 2 comments · Fixed by #4344
Closed

Incorrect Default Values in Eureka Appendix Documentation #4294

555cider opened this issue Jul 22, 2024 · 2 comments · Fixed by #4344
Assignees
Milestone

Comments

@555cider
Copy link
Contributor

I've discovered incorrect default values in the Eureka's Common application properties documentation.

The documentation file is located at "docs/modules/ROOT/partials/_configprops.adoc". I've attached a corrected version of the file(
_configprops.adoc.txt) saved as .txt for uploading.

The corrected items are as follows:

Name Default (before) Default (after)
eureka.client.eureka-service-url-poll-interval-seconds 0 300
eureka.server.a-s-g-update-interval-ms 0 300000
eureka.server.a-s-g-cache-expiry-timeout-ms 0 600000
eureka.server.e-i-p-binding-retry-interval-ms 0 300000
eureka.server.e-i-p-binding-retry-interval-ms-when-unbound 0 60000
eureka.server.renewal-threshold-update-interval-ms 0 900000
eureka.server.response-cache-update-interval-ms 0 30000
eureka.server.route53-binding-retry-interval-ms 0 300000
eureka.server.retention-time-in-m-s-in-delta-queue 0 180000
eureka.server.delta-retention-timer-interval-in-ms 0 30000
eureka.server.wait-time-in-ms-when-sync-empty 0 300000
eureka.client.rest-template-timeout.connect-timeout 0 180000
eureka.client.rest-template-timeout.connect-request-timeout 0 180000
eureka.client.rest-template-timeout.socket-timeout 0 180000
eureka.client.rest-template-timeout.idle-timeout (absent) 1800000
eureka.instance.secure-port-enabled false null

eureka.client.rest-template-timeout.idle-timeout is missing from the original documentation. A description for this property is "Indicates how long a connection can be idle before it is evicted from the connection pool." The behavior of eureka.instance.secure-port-enabled set to null is unclear. In the declaration, it's not initialized with false.

@OlgaMaciaszek
Copy link
Collaborator

Hello @555cider, thanks for reporting the issue. The values in the docs are, in fact, incorrect. Would you like to create a Pull Request with your changes?

555cider added a commit to 555cider/spring-cloud-netflix that referenced this issue Sep 6, 2024
555cider added a commit to 555cider/spring-cloud-netflix that referenced this issue Sep 26, 2024
@OlgaMaciaszek OlgaMaciaszek moved this to In Progress in 2024.0.0-M2 Sep 26, 2024
@OlgaMaciaszek OlgaMaciaszek linked a pull request Sep 26, 2024 that will close this issue
555cider added a commit to 555cider/spring-cloud-netflix that referenced this issue Sep 28, 2024
555cider added a commit to 555cider/spring-cloud-netflix that referenced this issue Sep 30, 2024
@OlgaMaciaszek OlgaMaciaszek linked a pull request Oct 2, 2024 that will close this issue
@OlgaMaciaszek OlgaMaciaszek moved this from In Progress to Done in 2023.0.4 Oct 2, 2024
@OlgaMaciaszek OlgaMaciaszek moved this from In Progress to Done in 2024.0.0-M2 Oct 2, 2024
@OlgaMaciaszek
Copy link
Collaborator

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Status: Done
2 participants