-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing observability support in RestTemplateTransportClientFactory #4255
Comments
ZIRAKrezovic
changed the title
Misleading usage of RestTemplate in DiscoveryClientOptionalArgsConfiguration
Missing observability support in RestTemplateTransportClientFactory
Feb 19, 2024
ZIRAKrezovic
added a commit
to ZIRAKrezovic/spring-cloud-netflix
that referenced
this issue
Feb 19, 2024
ZIRAKrezovic
added a commit
to ZIRAKrezovic/spring-cloud-netflix
that referenced
this issue
Feb 19, 2024
Thanks for reporting the issue, @ZIRAKrezovic. Makes sense. |
OlgaMaciaszek
pushed a commit
that referenced
this issue
Mar 26, 2024
Reopening as changes reverted due to broken tests. |
ZIRAKrezovic
added a commit
to ZIRAKrezovic/spring-cloud-netflix
that referenced
this issue
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I have just spent some hours debugging why
RestTemplate
is not propagating traces to Eureka Server. Turns outRestTemplateTransportClientFactory
creates aRestTemplate
instance by callingnew RestTemplate()
.To fix this,
RestTemplate.Builder
should be used to create aRestTemplate
inRestTemplateTransportClientFactory
and we get observability support for free.Now consider the WebFlux
WebClient
equivalentHere, as expected, the WebClient.Builder is used, and produced TransportClientFactory has observability support ...
Version: Spring Cloud Starter 2023.0.0
The text was updated successfully, but these errors were encountered: