Copy configuration from context ObjectMapper #1162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2024 09:22
|
@olegz this might be the better fix. |
|
This is how it was before/originally and it created a problem which actually did no harm to s-c-function application, but caused an adverse effect in other frameworks present at runtime. Basically by doing this we are modifying the ObjectMapper provided by boot. |
|
Hi @olegz, there is a small but significant difference to how it was before: the call to |
|
Sorry didn't notice that. Merging |
|
@olegz When will there be a new release of spring-cloud-function containing this fix? I can not find any planed release on calendar.spring.io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the change from 8b66fd2 that caused some regressions and tries to solve the problem in a different way: it just copies the original ObjectMapper before modifying it.
This should solve #1158 and #1159.