This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Changed occurrences of map calls on kafka streams to mapValues - Issue #357 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danishgarg Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@danishgarg Thank you for signing the Contributor License Agreement! |
|
@danishgarg did you verify these changes against your application? |
|
Yes @sobychacko. I verified against my app. It seems to be working correctly. |
|
Thank you @danishgarg for the PR. Looks good to me. Merged upstream and backported to 2.0.x. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the occurrences of stream.map calls to stream.mapValues when serializing/deserializing messages in order to avoid unnecessary re-partitioning.
Resolves #357