-
Notifications
You must be signed in to change notification settings - Fork 691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
=========================================
Coverage 72.48% 72.48%
Complexity 1837 1837
=========================================
Files 229 229
Lines 6774 6774
Branches 701 701
=========================================
Hits 4910 4910
Misses 1542 1542
Partials 322 322
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
=========================================
Coverage 70.95% 70.95%
Complexity 1800 1800
=========================================
Files 236 236
Lines 6776 6776
Branches 695 695
=========================================
Hits 4808 4808
Misses 1649 1649
Partials 319 319
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update the refdoc as well?
...d-gcp-starters/spring-cloud-gcp-starter-bigquery/src/main/resources/META-INF/spring.provides
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to update docs/src/main/asciidoc/sagan-index.adoc to include BigQuery, too, while you are at it?
Added refdoc, PTAL. |
docs/src/main/asciidoc/bigquery.adoc
Outdated
|
||
Spring Cloud GCP provides https://spring.io/projects/spring-integration[Spring Integration] message handlers which can be used to build pipelines that load data into BigQuery tables. | ||
|
||
Spring Cloud GCP the following message handlers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipped words? Singular vs plural?
docs/src/main/asciidoc/bigquery.adoc
Outdated
|
||
Spring Cloud GCP the following message handlers: | ||
|
||
* `BigQueryFileMessageHandler` - Handle messages containing data files and loads these into BigQuery tables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `BigQueryFileMessageHandler` - Handle messages containing data files and loads these into BigQuery tables. | |
* `BigQueryFileMessageHandler` - Handles messages containing data files and loads contents into BigQuery tables. |
@@ -0,0 +1,91 @@ | |||
== Google Cloud BigQuery | |||
|
|||
https://cloud.google.com/bigquery[Google Cloud BigQuery] is a fully managed, petabyte scale, low cost analytics data warehouse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about also documenting the starter and that it can be used to easily get an auto-wirable BigQuery
object?
Also, maybe document the spring.cloud.gcp.bigquery.*
properties like we do for other starters.
docs/src/main/asciidoc/bigquery.adoc
Outdated
==== Input Channel | ||
|
||
The `BigQueryFileMessageHandler` accepts messages whose payloads contain the data file being loaded. | ||
The accepted payload types include `byte[]`, `java.io.File`, or `java.io.InputStream`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is payload of type byte[]
the actual contents of the file or the file reference?
docs/src/main/asciidoc/bigquery.adoc
Outdated
|
||
|=========================================================================== | ||
| Message Header Name | Description | ||
| `DATASET_NAME` | Name of the BigQuery dataset that the file should be loaded to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we can also set the defaults for these through spring.cloud.gcp.bigquery.*
properties so that it just becomes configuration, rather than code.
@meltsufin - Changes made ! PTAL. |
I see that this starter project is not available in maven central version - 1.1.3.RELEASE. Any idea when is gonna be available? |
It will be part of the 1.2.0 Release. 1.2.0.M3 is scheduled for September 23rd. |
Add the BigQuery starter for the project.