dump json parameters with each run #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oseconds, helpful for distinguishing between parallel runs on the same filesystem. Also removed any export directory components associated with parameters now that there is a comprehensive params.json file dumped with each run.
Need to include minor bug fix to bring performance up to par with nature paper
|
It looks like the code for saving the network is commented out. Please put it back and I will merge. |
spragunr
added a commit
that referenced
this pull request
Oct 5, 2015
dump json parameters with each run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of json's structure it doesn't support serialization of anything other than "primitives" (so to speak - no such thing in python), necessitating conversion of the params object to a list containing only the serializable params, hence the weird list comprehension on line 120-122 of ale_agent.py.