Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default output handling in tensorflow task #181

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

andrewsmartin
Copy link
Contributor

We should remove this default output behavior and instead have users be explicit.

@andrewsmartin andrewsmartin force-pushed the andrew/tf-task-output branch 2 times, most recently from bbbcbbd to 67bff38 Compare March 3, 2019 19:13
@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #181 into master will decrease coverage by 0.05%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
- Coverage   89.08%   89.02%   -0.06%     
==========================================
  Files          12       12              
  Lines         733      720      -13     
==========================================
- Hits          653      641      -12     
+ Misses         80       79       -1
Impacted Files Coverage Δ
spotify_tensorflow/luigi/tensorflow_task.py 90.62% <75%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94e889...19ef06a. Read the comment docs.

@andrewsmartin andrewsmartin force-pushed the andrew/tf-task-output branch from 67bff38 to 19ef06a Compare March 3, 2019 19:42
Copy link
Contributor

@daikeshi daikeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this PR. It has been a while. LGTM! 👍

I'm fine with merging as it is although codcov is red. @brianmartin what do you think?

@andrewsmartin
Copy link
Contributor Author

Sorry, forgot about this one. I think our codecov settings are a little whack, seems like every time it decreases it turns the build red (though I haven't really verified for sure). @daikeshi @brianmartin @rclough are you fine to merge this?

@rclough rclough merged commit faee570 into master Jun 21, 2019
@andrewsmartin andrewsmartin deleted the andrew/tf-task-output branch June 21, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants