Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google-api-client dep override in scio-tensorflow #1180

Closed
wants to merge 1 commit into from

Conversation

regadas
Copy link
Contributor

@regadas regadas commented May 24, 2018

zoltar brings updated versions of google apis which conflict with beam ones.

@regadas regadas force-pushed the fix/google-api-client branch from 963b63b to 054f60b Compare May 24, 2018 19:49
@andrewsmartin
Copy link
Contributor

This version might cause issues with dataflow?GoogleCloudPlatform/DataflowJavaSDK#607

@codecov-io
Copy link

Codecov Report

Merging #1180 into master will decrease coverage by 10.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1180       +/-   ##
===========================================
- Coverage   82.65%   72.34%   -10.32%     
===========================================
  Files         122      122               
  Lines        4053     4053               
  Branches      434      435        +1     
===========================================
- Hits         3350     2932      -418     
- Misses        703     1121      +418
Impacted Files Coverage Δ
...scala/com/spotify/scio/bigquery/MockBigQuery.scala 0% <0%> (-95.13%) ⬇️
...la/com/spotify/scio/bigquery/dynamic/package.scala 0% <0%> (-94.45%) ⬇️
...cio/bigquery/dynamic/DynamicDestinationsUtil.scala 0% <0%> (-80%) ⬇️
...n/scala/com/spotify/scio/bigtable/TableAdmin.scala 0% <0%> (-80%) ⬇️
...ala/com/spotify/scio/bigquery/BigQueryClient.scala 14.11% <0%> (-67.57%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 45% <0%> (-55%) ⬇️
...ala/com/spotify/scio/avro/types/TypeProvider.scala 46.87% <0%> (-42.19%) ⬇️
...n/scala/com/spotify/scio/avro/types/AvroType.scala 55.55% <0%> (-33.34%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 68.75% <0%> (-25%) ⬇️
...in/scala/com/spotify/scio/bigtable/Mutations.scala 20% <0%> (-20%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4283f...054f60b. Read the comment docs.

@regadas
Copy link
Contributor Author

regadas commented May 24, 2018

@andrewsmartin oh yeah! I was bitten bu this before ... this makes things more interesting ...

Copy link
Contributor

@andrewsmartin andrewsmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above comment

@andrewsmartin
Copy link
Contributor

@regadas should we close this?

@regadas
Copy link
Contributor Author

regadas commented May 25, 2018

@andrewsmartin yeah let's close this one. I'm looking into alternative solution. #1173

@regadas regadas closed this May 25, 2018
@regadas regadas deleted the fix/google-api-client branch May 25, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants