Add more logging #55
Merged
Add more logging #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anish749
reviewed
Mar 24, 2019
| @@ -81,7 +81,9 @@ public JdbcConnectionArgs withPassword(String password) { | |||
|
|
|||
| public Connection createConnection() throws Exception { | |||
| Class.forName(driverClassName()); | |||
| Connection connection = DriverManager.getConnection(url(), username(), password()); | |||
| LOGGER.info("Creating JDBC connection to {} with user {}", | |||
There was a problem hiding this comment.
Are you sure?
I am not sure I follow. You removed the connection here?
There was a problem hiding this comment.
oops. My mistake.
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
============================================
+ Coverage 88.83% 88.98% +0.15%
- Complexity 155 156 +1
============================================
Files 21 21
Lines 573 581 +8
Branches 36 36
============================================
+ Hits 509 517 +8
Misses 46 46
Partials 18 18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this way it easier to help users troubleshoot.