Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password file system #37

Merged
merged 2 commits into from
Aug 6, 2018
Merged

Password file system #37

merged 2 commits into from
Aug 6, 2018

Conversation

labianchin
Copy link
Collaborator

Reads --passwordFile using Beam SDK FileSystems. This enables password to be stored both locally and in GCS.

@codecov-io
Copy link

codecov-io commented Aug 6, 2018

Codecov Report

Merging #37 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   88.84%   89.12%   +0.28%     
==========================================
  Files           7        7              
  Lines         233      239       +6     
  Branches       27       27              
==========================================
+ Hits          207      213       +6     
  Misses         26       26
Impacted Files Coverage Δ
...m/spotify/dbeam/options/DBeamPipelineOptions.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dbe93c...2f6eef7. Read the comment docs.

@labianchin labianchin merged commit 1163a61 into master Aug 6, 2018
@labianchin labianchin deleted the passwordFileSystem branch August 6, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants