Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete disabled assertion and its disabled test #172

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Delete disabled assertion and its disabled test #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
812185a
Delete disabled assertion and its disabled test
JensAyton Nov 17, 2020
1a1d015
Merge branch 'master' into rm-obsolete-assertion
kmcbride Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions MobiusExtras/Source/ConnectableClass.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,6 @@ open class ConnectableClass<Input, Output>: Connectable {
lock.unlock()
}
guard let consumer = consumer else {
#if false // Disabled because of flakiness and because public use of this class is being phased out.
MobiusHooks.errorHandler(
"\(type(of: self)) is unable to send \(type(of: output)) before any consumer has been set." +
"Send should only be used once the Connectable has been properly connected.",
#file,
#line
)
#endif
return
}

Expand Down
14 changes: 0 additions & 14 deletions MobiusExtras/Test/ConnectableClassTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,20 +90,6 @@ class ConnectableTests: QuickSpec {
}

context("when attempting to send some data back to the loop") {
context("when the consumer is not set") {
var sut: SubclassedConnectableClass!
beforeEach {
sut = SubclassedConnectableClass()
}

xit("should cause a mobius error") {
let errorThrown = catchError {
sut.send("Some string")
}
expect(errorThrown).to(beTrue())
}
}

context("when the consumer is set") {
var sut: SubclassedConnectableClass!
var consumerReceivedData: String?
Expand Down