Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connectable.map to MobiusExtras #150

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Add Connectable.map to MobiusExtras #150

merged 3 commits into from
Apr 20, 2020

Conversation

jeppes
Copy link
Contributor

@jeppes jeppes commented Apr 20, 2020

Requested by @anawara and others.
Also adds docs to Connectable.contramap.

@JensAyton, @pettermahlen

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          45       46    +1     
  Lines        1304     1304           
=======================================
  Hits         1221     1221           
  Misses         83       83           
Flag Coverage Δ
#ios 93.63% <100.00%> (ø)
#macspm 93.57% <100.00%> (ø)
Impacted Files Coverage Δ
MobiusExtras/Source/ConnectableContramap.swift 100.00% <100.00%> (ø)
MobiusExtras/Source/ConnectableMap.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8c7c0...a031592. Read the comment docs.

pettermahlen
pettermahlen previously approved these changes Apr 20, 2020
JensAyton
JensAyton previously approved these changes Apr 20, 2020
@jeppes jeppes dismissed stale reviews from JensAyton and pettermahlen via a031592 April 20, 2020 11:49
@jeppes jeppes requested a review from JensAyton April 20, 2020 11:49
@jeppes jeppes merged commit 6ef1e94 into master Apr 20, 2020
@jeppes jeppes deleted the connectable-map branch April 20, 2020 12:51
@kmcbride kmcbride mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants