-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]resize pvc #489
Merged
Merged
[feature]resize pvc #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// 1.Get the data already stored internally // 2.Get the desired data // 3.Start querying the pvc list when you find data inconsistencies // 3.1 Comparison using real pvc capacity and desired data // 3.1.1 Update if you find inconsistencies // 3.2 Writing successful updates to internal // 4. Set to old VolumeClaimTemplates to update.Prevent update error reporting // 5. Set to old annotations to update
@ese Any suggestions? |
1 similar comment
@ese Any suggestions? |
# Conflicts: # service/k8s/statefulset.go
@jiuker this is good feature... but should have some integration tests for this? |
@samof76 yeah.review plz |
ese
reviewed
Dec 9, 2022
I will do a deep review later. Sorry for the delay but I was not confident with resizing workflow. |
ese
reviewed
Dec 9, 2022
ese
reviewed
Dec 9, 2022
ese
reviewed
Dec 9, 2022
Thanks @jiuker. |
Co-authored-by: Sergio Ballesteros <snaker@locolandia.net>
Co-authored-by: Sergio Ballesteros <snaker@locolandia.net>
@ese review,plz |
ese
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pvc is too small,we can use it to make it bigger.
Fixes # .
Changes proposed on the PR: