Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]resize pvc #489

Merged
merged 10 commits into from
Dec 12, 2022
Merged

[feature]resize pvc #489

merged 10 commits into from
Dec 12, 2022

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Sep 22, 2022

// 1.Get the data already stored internally
// 2.Get the desired data
// 3.Start querying the pvc list when you find data inconsistencies
// 3.1 Comparison using real pvc capacity and desired data
// 3.1.1 Update if you find inconsistencies
// 3.2 Writing successful updates to internal
// 4. Set to old VolumeClaimTemplates to update.Prevent update error reporting
// 5. Set to old annotations to update

When pvc is too small,we can use it to make it bigger.
Fixes # .

Changes proposed on the PR:

  • Make pvc size bigger. When it need.

	// 1.Get the data already stored internally
	// 2.Get the desired data
	// 3.Start querying the pvc list when you find data inconsistencies
	// 3.1 Comparison using real pvc capacity and desired data
	// 3.1.1 Update if you find inconsistencies
	// 3.2 Writing successful updates to internal
	// 4. Set to old VolumeClaimTemplates to update.Prevent update error reporting
	// 5. Set to old annotations to update
@jiuker jiuker requested a review from a team as a code owner September 22, 2022 09:30
@jiuker
Copy link
Contributor Author

jiuker commented Sep 23, 2022

@ese Any suggestions?

1 similar comment
@jiuker
Copy link
Contributor Author

jiuker commented Oct 25, 2022

@ese Any suggestions?

guozhi.li added 2 commits November 25, 2022 10:58
# Conflicts:
#	service/k8s/statefulset.go
@samof76
Copy link
Contributor

samof76 commented Dec 5, 2022

@jiuker this is good feature... but should have some integration tests for this?

@jiuker
Copy link
Contributor Author

jiuker commented Dec 6, 2022

@samof76 yeah.review plz

@ese
Copy link
Member

ese commented Dec 9, 2022

I will do a deep review later. Sorry for the delay but I was not confident with resizing workflow.

@ese
Copy link
Member

ese commented Dec 9, 2022

Thanks @jiuker.

jiuker and others added 3 commits December 10, 2022 07:44
Co-authored-by: Sergio Ballesteros <snaker@locolandia.net>
Co-authored-by: Sergio Ballesteros <snaker@locolandia.net>
@jiuker
Copy link
Contributor Author

jiuker commented Dec 12, 2022

@ese review,plz

@ese ese merged commit ea7e74e into spotahome:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants