android less than 11 compression bitmap #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfir
approved these changes
May 9, 2024
src/android/SpectrumManager.java
Outdated
| @@ -80,6 +80,12 @@ private void transcodeImage(String path, int size, CallbackContext callbackConte | |||
| callbackContext.error("Failed to compress image"); | |||
| return; | |||
| } | |||
| } else { | |||
| Log.d("Warning","Cannot compress image on Android version < 11"); | |||
There was a problem hiding this comment.
Suggested change
| Log.d("Warning","Cannot compress image on Android version < 11"); | |
| Log.d("Warning","Cannot compress image on Android version < 11"); |
can we use callbackContext.error here
src/android/SpectrumManager.java
Outdated
| @@ -80,6 +80,12 @@ private void transcodeImage(String path, int size, CallbackContext callbackConte | |||
| callbackContext.error("Failed to compress image"); | |||
| return; | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
Shouldn't this be outside the try block?
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.R)
// error handling or logging
// return or equivalent
try (...)
// compress
HashirRajah
reviewed
May 10, 2024
src/android/SpectrumManager.java
Outdated
| @@ -80,6 +80,12 @@ private void transcodeImage(String path, int size, CallbackContext callbackConte | |||
| callbackContext.error("Failed to compress image"); | |||
| return; | |||
| } | |||
| } else { | |||
| Log.d("Warning","Cannot compress image on Android version < 11"); | |||
There was a problem hiding this comment.
Can we put < Build.VERSION_CODES.R instead of < 11 directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.