Don't publish jar signature artifacts for spock-bom #953
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, spock-bom was using `components.java` unnecessarily. As a side-effect, `spock-bom-*.jar.asc` was published alongside the POM.
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
=========================================
Coverage 75.99% 75.99%
Complexity 3534 3534
=========================================
Files 377 377
Lines 10742 10742
Branches 1367 1367
=========================================
Hits 8163 8163
Misses 2102 2102
Partials 477 477Continue to review full report at Codecov.
|
leonard84
approved these changes
Nov 29, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
mkutz
pushed a commit
to mkutz/spock
that referenced
this pull request
May 29, 2019
Prior to this commit, spock-bom was using `components.java` unnecessarily. As a side-effect, `spock-bom-*.jar.asc` was published alongside the POM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, spock-bom was using
components.javaunnecessarily. As a side-effect,
spock-bom-*.jar.ascwas publishedalongside the POM.
This PR was originally submitted as #951. However, the PR used the wrong base/target branch (
stable-publishinginstead ofmaster).This change is