WIP : JDK 17 upgrade

.github/workflows/release.yml

@@ -12,11 +12,12 @@ jobs:
     name: Java SDK Release
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set up JDK 1.8
-        uses: actions/setup-java@v1
+        uses: actions/setup-java@v4
         with:
-          java-version: 1.8
+          java-version: 17
+          distribution: oracle
           server-username: MAVEN_USERNAME
           server-password: MAVEN_PASSWORD
           server-id: splunk-artifactory
@@ -36,7 +37,7 @@ jobs:
           MAVEN_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}
 
       - name: Upload Artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: java_sdk_docs
           path: splunk/target/apidocs

.github/workflows/test.yml

@@ -11,7 +11,7 @@ jobs:
         os:
           - ubuntu-latest
         java-version:
-          - 1.8
+          - 17
         splunk-version:
           - "8.2"
           - "latest"
@@ -35,14 +35,15 @@ jobs:
           - 10668:10668/udp
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set up JDK
-        uses: actions/setup-java@v1
+        uses: actions/setup-java@v4
         with:
-          java-version: 1.8
+          distribution: oracle
+          java-version: 17
 
       - name: Cache local Maven repository
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}

pom.xml

@@ -9,8 +9,8 @@
         <version.number>1.9.5</version.number>
         <maven.resources.overwrite>true</maven.resources.overwrite>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <maven.compiler.source>8</maven.compiler.source>
-        <maven.compiler.target>8</maven.compiler.target>
+        <maven.compiler.source>17</maven.compiler.source>
+        <maven.compiler.target>17</maven.compiler.target>
     </properties>
 
     <groupId>com.splunk</groupId>

splunk/src/main/java/com/splunk/Args.java

@@ -154,8 +154,8 @@ public String encode() {
             if (builder.length() > 0) builder.append('&');
             String key = entry.getKey();
             Object value = entry.getValue();
-            if (value instanceof String[]) {
-                encodeValues(builder, key, (String[])value);
+            if (value instanceof String[] valueInst) {
+                encodeValues(builder, key, valueInst);
             }
             else {
                 builder.append(encode(key));

splunk/src/main/java/com/splunk/AtomFeed.java

@@ -20,14 +20,13 @@
 import java.util.*;
 import javax.xml.stream.XMLStreamException;
 import javax.xml.stream.XMLStreamReader;
-import javax.xml.stream.XMLStreamConstants;
 
 /**
  * The {@code AtomFeed} class represents an Atom feed.
  */
 public class AtomFeed extends AtomObject {
     /** The list of Atom entries contained in this {@code AtomFeed} object. */
-    public ArrayList<AtomEntry> entries = new ArrayList<AtomEntry>();
+    public ArrayList<AtomEntry> entries = new ArrayList<>();
 
     /** The value of the Atom feed's {@code <itemsPerPage>} element. */
     public String itemsPerPage = null;

splunk/src/main/java/com/splunk/AtomObject.java

@@ -34,7 +34,7 @@ public class AtomObject {
     public String id;
 
     /** The value of the {@code <link>} elements in this {@code AtomObject}. */
-    public Map<String, String> links = new HashMap<String, String>();
+    public Map<String, String> links = new HashMap<>();
 
     /** The value of the Atom {@code <title>} element. */
     public String title;