changed thp conditional to ansible_service_manager Fixes splunk/ansible-role-for-splunk#146 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,10 @@ | |||
|
|
|||
| - name: Disable THP | |||
| include_tasks: configure_thp.yml | |||
| when: "'full' in group_names" | |||
| when: | |||
| - ansible_service_mgr == "systemd" | |||
There was a problem hiding this comment.
Where is ansible_service_mgr defined?
| when: | ||
| - ansible_service_mgr == "systemd" | ||
| - ansible_connection != "docker" | ||
| - "'full' in group_names" |
There was a problem hiding this comment.
Are the double quotes around this necessary?
There was a problem hiding this comment.
Yes, it needs the double quotes
midnight5ky
approved these changes
Nov 21, 2022
dtwersky
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current conditional did not work right.
The limit on RedHat <6 was because of the lack of
systemd. Changing to usingansible_service_managerwill do the same thing, and is more descriptive of the reason why it's done that way.I moved it to the
configure_os.ymlso it can skip the wholeinclude_tasks.ymlaltogether instead of going through the whole task and skippin if it does not meet the requirements.