test: add integration tests #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c723cf to
b50df3c
Compare
artemrys
requested changes
Jan 4, 2024
| sudo /opt/splunk/bin/splunk restart | ||
| - name: run tests | ||
| run: | | ||
| poetry run pytest tests/integration | ||
| SPLUNK_ADMIN=admin SPLUNK_ADMIN_PWD=Chang3d! SPLUNK_USER=user SPLUNK_USER_PWD=Chang3d! poetry run pytest tests/integration |
There was a problem hiding this comment.
SPLUNK_ADMIN=admin -> SPLUNK_ADMIN=$SPLUNK_ADMIN?
artemrys
requested changes
Jan 5, 2024
| See splunkd.log/python.log for more details.</msg>""" | ||
| try: | ||
| response = requests.delete( | ||
| f"https://{host}:{management_port}/servicesNS/-/demo/demo_demo/dashboard", |
1813722 to
7aaa0ee
Compare
artemrys
requested changes
Jan 5, 2024
| from python handler: "REST Error [400]: Bad Request -- HTTP 400 Bad Request -- | ||
| b'{"messages":[{"type":"ERROR","text":"Object id=demo://test_input cannot be deleted in config=inputs."}]}'". | ||
| See splunkd.log/python.log for more details.</msg>""" | ||
| try: |
There was a problem hiding this comment.
Can we remove try / except and response.raise_for_status and instead check for response.status_code == 500? Same below.
There was a problem hiding this comment.
I don't want to have any logic in the tests, we should aim to have those tests as simple as we can.
artemrys
approved these changes
Jan 9, 2024
|
🎉 This PR is included in version 6.1.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extending integration tests to include status cases 400 and 403