Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prevent warnings about unhandled side effects #1552

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

vtsvetkov-splunk
Copy link
Contributor

Issue number:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

React 18 throws warning about unwrapped side effects in act.

Changes

  • Add implicit waiting when CustomControl finishes loading
  • proper usage of userEvent: docs

User experience

No changes

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Signed-off-by: Viktor Tsvetkov <142901247+vtsvetkov-splunk@users.noreply.github.com>
@vtsvetkov-splunk vtsvetkov-splunk requested a review from a team as a code owner January 28, 2025 09:52
@vtsvetkov-splunk vtsvetkov-splunk added the javascript Pull requests that update Javascript code label Jan 28, 2025
soleksy-splunk
soleksy-splunk previously approved these changes Jan 28, 2025
Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, just one question

@vtsvetkov-splunk vtsvetkov-splunk self-assigned this Jan 28, 2025
Signed-off-by: Viktor Tsvetkov <142901247+vtsvetkov-splunk@users.noreply.github.com>
Signed-off-by: Viktor Tsvetkov <142901247+vtsvetkov-splunk@users.noreply.github.com>
Signed-off-by: Viktor Tsvetkov <142901247+vtsvetkov-splunk@users.noreply.github.com>
@vtsvetkov-splunk vtsvetkov-splunk requested review from soleksy-splunk and a team January 28, 2025 10:37
@vtsvetkov-splunk vtsvetkov-splunk merged commit 2a418dd into develop Jan 29, 2025
123 checks passed
@vtsvetkov-splunk vtsvetkov-splunk deleted the feature/act-warnings-tests branch January 29, 2025 08:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript Pull requests that update Javascript code size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants