Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not require calls of _reload endpoint #1547

Merged
merged 7 commits into from
Feb 4, 2025
Merged

fix: do not require calls of _reload endpoint #1547

merged 7 commits into from
Feb 4, 2025

Conversation

artemrys
Copy link
Member

@artemrys artemrys commented Jan 24, 2025 •
edited by kkedziak-splunk
Loading

Issue number: ADDON-77916

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

This change uses the exposed interface to set need_reload from splunktaucclib to False by default in order to prevent reloads of selected endpoints.

User experience

Improves the performance of the add-ons built using UCC and those that are using splunktaucclib to not require reloads during API calls to the endpoints.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@artemrys artemrys changed the base branch from develop to main January 24, 2025 16:05
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 30, 2025
@kkedziak-splunk kkedziak-splunk marked this pull request as ready for review February 3, 2025 13:37
@kkedziak-splunk kkedziak-splunk requested a review from a team as a code owner February 3, 2025 13:37
kkedziak-splunk
kkedziak-splunk previously approved these changes Feb 4, 2025
View reviewed changes
sgoral-splunk
sgoral-splunk previously approved these changes Feb 4, 2025
View reviewed changes
@kkedziak-splunk kkedziak-splunk dismissed stale reviews from sgoral-splunk and themself via 8cf14f1 February 4, 2025 15:53
@kkedziak-splunk kkedziak-splunk requested review from a team as code owners February 4, 2025 15:53
kkedziak-splunk
kkedziak-splunk previously approved these changes Feb 4, 2025
View reviewed changes
@kkedziak-splunk kkedziak-splunk changed the base branch from main to develop February 4, 2025 15:56
@kkedziak-splunk kkedziak-splunk dismissed their stale review February 4, 2025 15:56

The base branch was changed.

@kkedziak-splunk kkedziak-splunk enabled auto-merge (squash) February 4, 2025 15:58
@kkedziak-splunk kkedziak-splunk merged commit a39c8c0 into develop Feb 4, 2025
123 checks passed
@kkedziak-splunk kkedziak-splunk deleted the fix/need_reload branch February 4, 2025 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sgoral-splunk sgoral-splunk sgoral-splunk approved these changes

@kkedziak-splunk kkedziak-splunk kkedziak-splunk approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemrys @sgoral-splunk @kkedziak-splunk