Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove file-based input #184

Merged
merged 2 commits into from
Jan 8, 2025
Merged

feat: remove file-based input #184

merged 2 commits into from
Jan 8, 2025

Conversation

artemrys
Copy link
Member

@artemrys artemrys commented Jan 8, 2025

This PR removes necessity to have a .addonmatrix file in the root of the directory to configure which versions of Splunk need to be tested.

I do not believe that file was ever changed so there is no need as of now to provide it as an input parameter in action.yml but this option is on the table in case it will be needed in the future.

I believe it's safe to mark it as a breaking change in case someone uses non-default value in .addonmatrix file. Please reach out and we will expose --splunkfeatures parameter through action.yml file.

BREAKING CHANGE: remove file-based input

BREAKING CHANGE: remove file-based input
@artemrys artemrys requested a review from a team as a code owner January 8, 2025 15:38
@artemrys
Copy link
Member Author

artemrys commented Jan 8, 2025

Test run - splunk/addonfactory-ucc-generator#1525.

@artemrys artemrys merged commit 2edce07 into main Jan 8, 2025
3 checks passed
@artemrys artemrys deleted the deprecate-file-input branch January 8, 2025 16:17
srv-rr-github-token added a commit that referenced this pull request Jan 8, 2025
# [3.0.0](v2.1.12...v3.0.0) (2025-01-08)

### Features

* remove file-based input ([#184](#184)) ([2edce07](2edce07))

### BREAKING CHANGES

* remove file-based input
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants