-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bulletin_rest_client module to manage global Splunk messages #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9b1d0e
to
da624ff
Compare
artemrys
requested changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add tests: unit and e2e?
artemrys
requested changes
Jun 18, 2024
kkedziak-splunk
previously approved these changes
Jun 18, 2024
hetangmodi-crest
previously approved these changes
Jun 19, 2024
artemrys
requested changes
Jun 19, 2024
artemrys
reviewed
Jun 20, 2024
artemrys
approved these changes
Jun 23, 2024
🎉 This PR is included in version 5.1.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:ADDON-70528
Summary
Create REST client to manage bulletin messages in splunk.
Changes
User experience
The user can better manage events in add-on by creating specific messages in the Splunk bulletin. Every message has 3 severity levels: info, warn, error. The user can also delete or read those messages at code lvl with the use of REST client.
Checklist
If your change doesn't seem to apply, please leave them unchecked.