Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bulletin_rest_client module to manage global Splunk messages #369

Merged
merged 10 commits into from
Jun 23, 2024

Conversation

sgoral-splunk
Copy link
Contributor

@sgoral-splunk sgoral-splunk commented Jun 17, 2024

Issue number:ADDON-70528

Summary

Create REST client to manage bulletin messages in splunk.

Changes

  • add bulletin_rest_client module with basic methods: CREATE, GET, GET ALL, DELETE

User experience

The user can better manage events in add-on by creating specific messages in the Splunk bulletin. Every message has 3 severity levels: info, warn, error. The user can also delete or read those messages at code lvl with the use of REST client.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@sgoral-splunk sgoral-splunk requested a review from a team as a code owner June 17, 2024 07:56
@sgoral-splunk sgoral-splunk force-pushed the feat/send_msg_to_bulletin branch from c9b1d0e to da624ff Compare June 17, 2024 08:02
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add tests: unit and e2e?

@sgoral-splunk sgoral-splunk requested a review from artemrys June 17, 2024 13:33
@artemrys artemrys changed the title feat: add bulletin_rest_client module to manage global splunk messages feat: add bulletin_rest_client module to manage global Splunk messages Jun 19, 2024
@artemrys artemrys merged commit 829d1cb into develop Jun 23, 2024
13 of 14 checks passed
@artemrys artemrys deleted the feat/send_msg_to_bulletin branch June 23, 2024 10:06
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.1.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants