Feature: AppDynamics data link

[chrjosep]

Feature

• In order to further integrate AppDynamics with Splunk o11y, we are adding data links that deep link to AppDynamics CSaaS.
• Add target_appd_url to data link resource
• Bump signalfx-go version

Usage

• Run a Terraform file using the new target_appd_url field on a data link resource.

Implementation

• Conditional check on data link type. Followed style for existing data link types (target_external_url, target_splunk, etc.).
• URL validation checks for target_appd_url
• Error handling for URL validation. Returns an error if input URL does not match AppDynamics regex pattern.
  • URL should contain .saas.appdynamics.com, query values component and application. The query values should be positive integers

Testing

• Manually tested by generating local binary and running Terraform module with development_overrides flag.
• Acceptance tests:
  • Valid target_appd_url url that should create and destroy a data link without errors
  • A target_appd_url with a missing query parameter component. This should throw an error in the URL validation logic.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[chrjosep]

I have read the CLA Document and I hereby sign the CLA

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (2eac7d3) to head (0945251).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          35       35           
  Lines        2107     2107           
=======================================
  Hits         1999     1999           
  Misses         89       89           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MovieStoreGuy]

Just a comment from me.

[MovieStoreGuy]

Avoid using MustCompile or Must* methods in general since on error they will panic causing state to be incorrectly set if this was to be in the middle in an apply.

Be sure to use Compile instead and return the error.

[MovieStoreGuy]

Do you mind expanding on what the regular expression is testing?

Reading it it looks like you can have any wildcard for *.saas.appdynamics.com and expecting to have the query values for application, and component?

Did I miss anything here?

[chrjosep]

Yes that is correct. The other condition would be that the query values for application and component need to be positive integers.