slo: dedicated slo resource in terraform provider #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoubowicz
reviewed
Feb 8, 2024
ahoubowicz
approved these changes
Feb 8, 2024
ahoubowicz
approved these changes
Feb 8, 2024
|
@dwalasek you can upgrade the Go version in go.mod to 1.20 and update the CI to use that. |
|
@benkeith-splunk Thx for review, I've upgraded go version - could you please approve again? |
|
The CI thing isn't working, see https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-go#using-a-specific-go-version and try upgrading the setup-go action to v4. |
|
@benkeith-splunk I updated the setup-go action to version 4, but the error message is not really meaningful to me. Sorry to bother you, but could you restart the workflow? (unfortunately I'm not able to do it myself) |
Co-authored-by: Ben Keith <130169123+benkeith-splunk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slo: dedicated slo resource in terraform provider