Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[f5bigipltm] - Bugfix: Remove requests dependency #9

Merged
merged 12 commits into from
Apr 2, 2024

Conversation

sodle-splunk
Copy link
Contributor

@sodle-splunk sodle-splunk commented Mar 25, 2024

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
    • N/A
  • If this is a new connector or you are adding new actions
    • N/A
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
    • N/A
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
    • N/A
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    • N/A

Release Notes (REQUIRED)

  • Remove the requests dependency, instead using the one built into the SOAR platform

Thanks for contributing!

@sodle-splunk
Copy link
Contributor Author

sodle-splunk commented Mar 29, 2024 via email

@sodle-splunk sodle-splunk changed the title [f5bigip] - Bugfix: Remove requests dependency [f5bigipltm] - Bugfix: Remove requests dependency Apr 2, 2024
@sodle-splunk sodle-splunk merged commit ddc3aaa into next Apr 2, 2024
@sodle-splunk sodle-splunk deleted the sodle/PAPP-3343 branch April 2, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants