-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAPP-34356 initial code update for new list alerts api #50
Conversation
…nt, and linting via pipeline
…/crowdstrikeoauth into tcihak-PAPP-34356 updated README
…/crowdstrikeoauth into tcihak-PAPP-34356
I believe the sanity and integration tests are failing due to scheduled polling problems - however if you follow the AWS links to the failed tests you'll see that with the exception of 1 or 2 flaky sanity tests, all are passing. All 32 of the playbooks are also passing, which you can verify in the links. I'm not sure why the scheduled polling is consistently failing, and my attempt to research didn't return any results. I am not seeing it passing in previous attempts either? It always errors out with "message": "Failed to execute action 'on poll' on asset '10898'. Error: shutdown while waiting for action result.. ", Finally, apologies for the number of line changes but the new linting using black replaced single with double quotes everywhere and this app is pretty large. My actual changes were to update the Handle_list_incidents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left one suggestion to consider
CS Ingestion tests have been flaky for a long time... I think it's dependent on whether we can keep a steady stream of alerts flowing into the platform? |
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md
.the Vault API.
nosemgrep
?If yes, please provide justification in an additional comment next to the ignored code.
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!