Stats in JSON format #686
Merged
Stats in JSON format #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed code not entering the inital "Stats" section. Moved the section name extraction to avoid messing with the traversal stack.
splewis
reviewed
Jul 17, 2021
| } | ||
| } | ||
|
|
||
| public bool DumpToFilePath(const char[] path) { |
There was a problem hiding this comment.
A suggestion:
- Add a generic
IsJSONPathfunction to util.sp - That implementation can be simplified doing something like:
StrCompare(path[path_length - 5], ".json") == 0(after validating path_length > 5 still) - Replace this with a call to that function
- Make this function:
return IsJSONPath(path) : DumpToJSONFile(path) : g_StatsKv.ExportToFile(path);
There was a problem hiding this comment.
Implemented in a3e9d2b
splewis
reviewed
Jul 17, 2021
| } | ||
|
|
||
| char jsonBuffer[8192]; // 8 KiB |
There was a problem hiding this comment.
I'm not sure how large the json data is in practice TBH, I'm wondering if 8KiB is enough; do you have a sense of the size for a normal 10-person 3-map match?
There was a problem hiding this comment.
This was a guess based on intuition. I tried 32 KiB but that crashed with a out of heap or stack space error (I don't recall which)
IsJSONPath checks if the path ends in ".json". Change DumpToFilePath and LoadMatchFile to use IsJSONPath.
|
Hi, sir I have just started this project about JSON match stats. If you are able to send match stats JSON body as a POST request to a server set with get5_match_stats_api_url that would be awesome! Erkut |
PhlexPlexico
added a commit
to PhlexPlexico/get5
that referenced
this pull request
Dec 16, 2021
Add in global forwards. Update debug calls. Update misused sizeof. Include timer to make sure unpause event fires off. Having to create new timer to keep track of unpause event. Additional comments. Move team for when timer is finished. Include global handler for p;ause time. This is needed if users !pause during the match. Use freeze time, it works as intended. Fixes based on comments. Remove Handler. Bump to 0.8.0-dev, since splewis#612 will have breaking eventlogger changes. (Squashed): Added knife kills, utility damage and enemies/team-flash tracking (splewis#612) Use game-provided flash-assist logic Stats in JSON format (splewis#686) * Dump stats in JSON format * update sm-json * Fix malformed JSON stats Fixed code not entering the inital "Stats" section. Moved the section name extraction to avoid messing with the traversal stack. * Reduced JSON stats buffer to avoid "out of heap" errors * Add debug log when trying to JSON encode unsupported type * Only dump stats in JSON format if stats file have json extension * Util function for checking json extension IsJSONPath checks if the path ends in ".json". Change DumpToFilePath and LoadMatchFile to use IsJSONPath.
PhlexPlexico
added a commit
to PhlexPlexico/get5
that referenced
this pull request
Dec 16, 2021
Add in global forwards. Update debug calls. Update misused sizeof. Include timer to make sure unpause event fires off. Having to create new timer to keep track of unpause event. Additional comments. Move team for when timer is finished. Include global handler for p;ause time. This is needed if users !pause during the match. Use freeze time, it works as intended. Fixes based on comments. Remove Handler. Bump to 0.8.0-dev, since splewis#612 will have breaking eventlogger changes. (Squashed): Added knife kills, utility damage and enemies/team-flash tracking (splewis#612) Use game-provided flash-assist logic Stats in JSON format (splewis#686) * Dump stats in JSON format * update sm-json * Fix malformed JSON stats Fixed code not entering the inital "Stats" section. Moved the section name extraction to avoid messing with the traversal stack. * Reduced JSON stats buffer to avoid "out of heap" errors * Add debug log when trying to JSON encode unsupported type * Only dump stats in JSON format if stats file have json extension * Util function for checking json extension IsJSONPath checks if the path ends in ".json". Change DumpToFilePath and LoadMatchFile to use IsJSONPath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for writing stats in JSON format.
The feature is enabled by setting the
get5_stats_path_formatcvar to a value ending in.jsonThe work is paid for in part by ehub.gg