-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store server ID in match table #613
Conversation
That's how natives work in SourceMod. A native can either use the usual For example, with And in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more conventional "return the integer"-way is fine imo, this is what is done with Get5_MatchTeamToCSTeam()
and Get5_IncreasePlayerStat()
.
For anyone using the MySQL plugin; you must run this command on the get5 database when this gets merged:
|
Hey @Drarig29 I made a few adjustments to the SQL script while we're at it.
All of the above is backwards-compatible (except of course for the original addition of the server_id column). |
I'm OK with 1. and 3. but maybe @splewis should take a look into 2. I'm OK with 2. too but I might forget something. |
So i have made the changes to the SQL database that @nickdnk posted. |
Don't do it yet, the PR is still open and more changes could be added. |
Ok thank you for reply @Drarig29 :) |
Hello
As discussed in #584.
But there's some code here I don't understand. This PR needs some help as I'm not 100% sure this is right. Can you explain why this code has reversed get/set logic and always returns 0? That makes no sense at all to me.
get5/scripting/get5/natives.sp
Lines 185 to 195 in 013519d
I ask because I used the same pattern for this PR. I did it in the more conventional "return the integer"-way though, which may be wrong.
CC @RuneNyhuus