Raycast fn using fast traversal #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added `voxel_line_traversal` and `voxel_cartesian_traversal` for versatile and fast traversal of the voxel grid + Created a new bevy_voxel_world::traversal_alg module to make it easy for crate users to import those algorithms + Added VoxelFace enum to represent the face of a voxel, automatically imported by the prelude + Added VOXEL_SIZE constant (because I was uncomfortable implicitly using the fact that voxels are unit-sized) + Added an example showing how to use and debug voxel traces
Returns Err for VoxelFace::None, Ok for regular faces.
+ New get_bounds function on ChunkMap + Updating or removing chunks automatically updates the bounds
+ VoxelRaycastResult::normal is now an Option<Vec3>, which is None when the raycast result is the voxel from which the trace originated from
|
I've executed the benchmarks and the new algo is outperforming the old one by quite much. You can find the benchmark code on this branch if you want to see by yourself! To test, just checkout this branch and run
|
splashdust
approved these changes
Jun 5, 2024
|
Good catch on the fixes you made ! And thanks for merging <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could successfully replace the step algorithm you were using by the new voxel line traversal for the same results. I leave this in draft though as this PR depends on the other to be approved first. Also, I'd like to do some benchmark to make sure the performance are equal or better.