fix: bitpacking respects patches and zero bit width cases #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a few issues: 1. When bit width is zero, we still must apply patches. 2. When bit width is zero, we should only push zeros into the values because the nulls are already handled three lines above (the call to `append_validity`) 3. Tests for many of the cases of bitpacked array.
danking
commented
Feb 14, 2025
| if bit_width == 0 { | ||
| builder.append_zeros(length); |
There was a problem hiding this comment.
NB: append_zeros also appends is_valids, so we end up with twice the number of validity entries.
robert3005
reviewed
Feb 15, 2025
robert3005
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues:
When bit width is zero, we still must apply patches.
When bit width is zero, we should only push zeros into the values because the nulls are already handled three lines above (the call to
append_validity)Tests for many of the cases of bitpacked array.
Looks better with whitespace changes hidden.