Fix take with nullable indices on arrays with patches #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
approved these changes
Feb 12, 2025
robert3005
commented
Feb 12, 2025
Comment on lines
+25
to
+28
| let right_parts = fill_null( | ||
| take(array.right_parts(), indices)?, | ||
| Scalar::new(array.right_parts().dtype().clone(), ScalarValue::from(0)), | ||
| )?; |
There was a problem hiding this comment.
Should add a thing to alp-rd to not require right parts to be nonnullable and just fill in the value with 0 (left parts will be null anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the array is nonnullable after a take it might end up being nullable,
however, same take might not affect the values of patches thus resulting in
nonullable patches. Need to ensure that after take the patches values have same
nullability as the target array