Fix: Don't ignore benchmarks on develop (#2378)

spiraldb · Feb 17, 2025 · 548d7f2 · 548d7f2
1 parent 2bd1c66
commit 548d7f2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml
@@ -130,7 +130,6 @@ jobs:
       matrix:
         benchmark:
           - id: random_access
-            bin: random_access
             name: Random Access
     if: ${{ contains(github.event.head_commit.message, '[benchmark]') || github.event.label.name == 'benchmark' && github.event_name == 'pull_request' }}
     steps:
@@ -155,7 +154,7 @@ jobs:
           BENCH_VORTEX_RATIOS: '.*'
           RUSTFLAGS: '-C target-cpu=native'
         run: |
-          cargo run --bin ${{ matrix.benchmark.bin }} --release -- -d gh-json -t 1 | tee tpch.json
+          cargo run --bin ${{ matrix.benchmark.id }} --release -- -d gh-json -t 1 | tee tpch.json
 
       - name: Setup AWS CLI
         uses: aws-actions/configure-aws-credentials@v4

diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml
@@ -113,9 +113,7 @@ jobs:
       matrix:
         benchmark:
           - id: random_access
-            bin: random_access
             name: Random Access
-    if: ${{ contains(github.event.head_commit.message, '[benchmark]') || github.event.label.name == 'benchmark' && github.event_name == 'pull_request' }}
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/cleanup
@@ -138,7 +136,7 @@ jobs:
           BENCH_VORTEX_RATIOS: '.*'
           RUSTFLAGS: '-C target-cpu=native'
         run: |
-          cargo run --bin ${{ matrix.benchmark.bin }} --release -- -d gh-json | tee ${{ matrix.benchmark.id }}.json
+          cargo run --bin ${{ matrix.benchmark.id }} --release -- -d gh-json | tee ${{ matrix.benchmark.id }}.json
 
       - name: Setup AWS CLI
         uses: aws-actions/configure-aws-credentials@v4

diff --git a/.github/workflows/sql-benchmarks.yml b/.github/workflows/sql-benchmarks.yml
@@ -14,12 +14,9 @@ jobs:
       matrix:
         benchmark:
           - id: tpch
-            bin: tpch
             name: TPC-H
           - id: clickbench
-            bin: clickbench
             name: Clickbench
-    if: ${{ contains(github.event.head_commit.message, '[benchmark]') || github.event.label.name == 'benchmark' && github.event_name == 'pull_request' }}
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/cleanup
@@ -35,7 +32,7 @@ jobs:
           BENCH_VORTEX_RATIOS: '.*'
           RUSTFLAGS: '-C target-cpu=native'
         run: |
-          cargo run --bin ${{ matrix.benchmark.bin }} --release -- -d gh-json | tee ${{ matrix.benchmark.id }}.json
+          cargo run --bin ${{ matrix.benchmark.id }} --release -- -d gh-json | tee ${{ matrix.benchmark.id }}.json
 
       - name: Setup AWS CLI
         uses: aws-actions/configure-aws-credentials@v4