Fix PHP 8.4 deprecation warnings #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit nullable parameter types are deprecated in PHP 8.4. This could be fixed by using "?", but this requires at least PHP 7.1 whereas this package still supports PHP 5.6.
As of PHP 8.4.0, depending on the default value of escape is deprecated.
This was referenced Dec 4, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using this package with PHP 8.4 and it seems to work fine for my use cases.
However, I noticed the following deprecation warnings which should be fixed by this PR:
fgetcsv(): depending on the default value ofescapeis deprecated (see https://www.php.net/manual/en/function.fgetcsv.php)