Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix param list to call write2DBarcode() #568

Merged
merged 1 commit into from
Jun 23, 2020
Merged

fix param list to call write2DBarcode() #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MyPdf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,7 +1345,7 @@ public function myBarcode($code, $type, $x, $y, $w, $h, $labelFontsize, $color,
// build the barcode
if ($dimension === '2D') {
// PDF417, DATAMATRIX ...
$this->write2DBarcode($code, $type, $x, $y, $w, $h, '', $style, 'N');
$this->write2DBarcode($code, $type, $x, $y, $w, $h, $style, 'N');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest remove $style['position'] = 'S'; for write2DBarcode because it makes unreadable Barcode

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not hesitate to create a new PR :)

} else {
$this->write1DBarcode($code, $type, $x, $y, $w, $h, '', $style, 'N');
}
Expand Down