Updating README for local development #96
Conversation
|
|
||
| ## Environment Setup | ||
| . git clone git@github.com:spinnaker/rosco.git | ||
| . git clone https://github.com/spinnaker/spinnaker.git |
There was a problem hiding this comment.
Should probably use the same-style url's here.
There was a problem hiding this comment.
swagger-ui.html is the actual url it goes to.
|
The file doesn't render properly using github's View button. Please use github-flavored markdown to annotate code snippets and urls. |
|
|
| . git clone git@github.com:spinnaker/rosco.git | ||
| . git clone https://github.com/spinnaker/spinnaker.git | ||
| ``` | ||
| git clone git@github.com:spinnaker/rosco.git |
There was a problem hiding this comment.
One url is git@... and one is https://....
| (printf "PING\r\n";) | nc -v localhost 6379 | ||
| ``` | ||
|
|
||
| # IDE setup |
There was a problem hiding this comment.
Sorry, what I meant was that the gradle wrapper line, which I think is a comment, should begin with a #.
| @@ -0,0 +1,23 @@ | |||
| <code_scheme name="spinnaker"> | |||
There was a problem hiding this comment.
If this formatting template is applied to the currently committed codebase, are changes made?
There was a problem hiding this comment.
I'm not an expert on intellij, so I'm mainly looking to confirm that if somebody follows the 2 steps in 'Apply groovy code formatting scheme', that no reformatting immediately takes place.
There was a problem hiding this comment.
No - you still need to highlight the code you want and apply the reformat command.
|
I found another gap in the documentation - I want to submit a request to Rush, however, since it runs a containerized packer build, it is not able to find my packer template (which is outside of the container). How do you suggest getting this to work for local development? |
|
LGTM. |
|
|
|
Rush relies on the script executor abstraction to run the jobs requested by rosco. There are two implementations, local and docker. Only the local implementation is supported. The docker artifacts are there for (not very compelling) historical reasons. It originally only supported running docker containers and we weren't sure when we were doing the initial refactoring if somebody would want to reenable that support for running non-bake jobs in pipelines (this was the initial domain of rush). Now that there is solid support for running jobs via the kubernetes integration, this is no longer a concern. As part of the in-progress merging of rush into rosco all the deprecated ScriptExecutorDocker stuff is being dropped. When you develop locally, you'll need to ensure that |
|
Btw, this ties back into our early conversation about the |
Update README for local development. Add code style guidelines for IntelliJ. Update Authors.
Update README for local development. Add code style guidelines for IntelliJ. Update Authors.
No description provided.