fix(sql): Create SqlActiveExecutionsMonitor via autoconfiguration instead of @Component #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of @component When this bean is created via @component it fails to find the qualifier bean sqlExecutionRepository when qos is disabled. I can not say I really understand why. Now, the qualifier bean sqlExecutionRepository is found regardless of qos enabled/disabled.
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…tead of @component (spinnaker#3861) When this bean is created via @component it fails to find the qualifier bean sqlExecutionRepository when qos is disabled. I can not say I really understand why. Now, the qualifier bean sqlExecutionRepository is found regardless of qos enabled/disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this bean is created via
@Componentit fails to find the qualifier bean sqlExecutionRepository when qos is disabled. I can not say I really understand why. Now, the qualifier bean sqlExecutionRepository is found regardless of qos enabled/disabled.