feat(destroy): Add a flag to be able to skip the disable of destroy stage #3858
Conversation
…tage Add an experimental flag `forceSkipDisable` to the `DestroyServerGroupStage` so that applications that don't participate in discovery can skip disable step which should speed up their destruction operation.
| it.name = "disableServerGroup" | ||
| it.type = getType(DisableServerGroupStage) | ||
| it.context.putAll(context) | ||
| boolean skipDisable = (boolean)context.getOrDefault("forceSkipDisable", false) |
There was a problem hiding this comment.
nit ... maybe shouldDisableBeforeDestroy (default to true) vs forceSkipDisable (default to false).
Otherwise I think this is a useful flag!
There was a problem hiding this comment.
I prefer props that aren't there to be false. But in this very limited (from code perspective) use case it feels less consequential. I also thought having more strong language e.g. force would be good since most people shouldn't be setting the flag so when it's set, hopefully it stands out a bit
There was a problem hiding this comment.
Agree with the default-to-false idea, makes good sense to me.
Going to merge this as we're following up with RTDI today ... I added a log message and comments (and s/forceSkipDisable/skipDisableBeforeDestroy 🌺 ).
…tage (spinnaker#3858) Add an experimental flag `skipDisableBeforeDestroy` to the `DestroyServerGroupStage` so that applications that don't participate in discovery can skip disable step which should speed up their destruction operation. Co-authored-by: Adam Jordens <adam@jordens.org>
Add an experimental flag
forceSkipDisableto theDestroyServerGroupStageso that applications that don't participate in discovery can skip disable step which should speed up their destruction operation.