Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runjob): add ability to read props file even if job fails #3855

Merged
merged 2 commits into from
Aug 11, 2020
Merged

feat(runjob): add ability to read props file even if job fails #3855

merged 2 commits into from
Aug 11, 2020

Conversation

marchello2000
Copy link
Contributor

No description provided.

@marchello2000 marchello2000 requested a review from emjburns August 10, 2020 22:12
@marchello2000 marchello2000 added the ready to merge Approved and ready for merge label Aug 11, 2020
@mergify mergify bot merged commit 63a3322 into spinnaker:master Aug 11, 2020
@mergify mergify bot added the auto merged Merged automatically by a bot label Aug 11, 2020
@marchello2000 marchello2000 deleted the mark/read_props_for_job_on_error branch August 11, 2020 05:07
KathrynLewis pushed a commit to KathrynLewis/orca that referenced this pull request Jan 31, 2021
@marchello2000 @KathrynLewis
feat(runjob): add ability to read props file even if job fails (spinn…
0496d8c 
…aker#3855)

* feat(runjob): add ability to read props file even if job fails

* fixup! feat(runjob): add ability to read props file even if job fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emjburns emjburns emjburns approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.22
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marchello2000 @emjburns @spinnakerbot