fix(destroy): add disable stage to destroy server group stage #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's add it as a beforeStage instead of duplicating the tasks in the disable stage. In particular, the task graph of DestroyServerGroupStage was missing a determineHealthProviderTask and using the now-deprecated WaitForAllInstancesNotUpTask.
christopherthielen
approved these changes
Aug 6, 2020
|
Does this all wire up nice in the UI? (I also don't understand preStatic/preDynamic any more) |
yeah it should be good |
marchello2000
approved these changes
Aug 7, 2020
cfieber
approved these changes
Aug 7, 2020
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…ker#3848) Let's add it as a beforeStage instead of duplicating the tasks in the disable stage. In particular, the task graph of DestroyServerGroupStage was missing a determineHealthProviderTask and using the now-deprecated WaitForAllInstancesNotUpTask. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add it as a beforeStage instead of duplicating the tasks in the disable stage.
In particular, the task graph of DestroyServerGroupStage was missing a determineHealthProviderTask
and using the now-deprecated WaitForAllInstancesNotUpTask.