fix(exceptions): add exception handler for exceptional situations #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfieber
reviewed
Aug 6, 2020
| @@ -478,4 +480,11 @@ class OperationsController { | |||
| pipeline.origin = AuthenticatedRequest.spinnakerUserOrigin.orElse('unknown') | |||
| } | |||
| } | |||
|
|
|||
| @ExceptionHandler(UserException.class) | |||
| static void handleUserExceptions(UserException e, HttpServletResponse response) { | |||
There was a problem hiding this comment.
do our generic error handlers in kork not handle UserException as a 400 already?
I think if they do, they will serve a json payload with some details instead of a text response - might play slightly nicer with handling API responses if they come back that way
There was a problem hiding this comment.
oh... i didn't see it let me look/try, thanks!
There was a problem hiding this comment.
doesn't look like it, but i can add one to kork, that will obviate the need for them here
|
https://github.com/spinnaker/kork/pull/737/files will update this PR |
When a user submits a bad pipeline e.g. * with jenkins trigger that has an invalid properties file or job that doesn't exist) * with a broken pipeline template we don't want to 500 because: a) the calling service (echo in most cases here) will keep retrying which makes no sense b) it's an erroneous HTTP 500 metric that is noise
c37251e to
87dab93
Compare
1. Don't log task failures on `UserException` 2. Don't fail retrieving properties file if the build wasn't started
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…innaker#3845) * fix(exceptions): add exceptionhandler for non-excpetional situations When a user submits a bad pipeline e.g. * with jenkins trigger that has an invalid properties file or job that doesn't exist) * with a broken pipeline template we don't want to 500 because: a) the calling service (echo in most cases here) will keep retrying which makes no sense b) it's an erroneous HTTP 500 metric that is noise * fix(exceptions): fix various exception issues 1. Don't log task failures on `UserException` 2. Don't fail retrieving properties file if the build wasn't started * fixup! Merge branch 'master' into mark/exceptionhandlers Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user submits a bad pipeline e.g.
we don't want to 500 because:
a) the calling service (echo in most cases here) will keep retrying which makes no sense
b) it's an erroneous HTTP 500 metric that is noise