fix(exceptions): Don't let errors in trackResult leak out
#3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for trackResult metrics call to fail and we don't want that failure to leak out and fail orca tasks
marchello2000
commented
Aug 6, 2020
| @@ -58,9 +58,12 @@ default String getCredentials(Map<String, Object> context) { | |||
|
|
|||
| // may return a list with 0, 1 or more regions (no guarantees on the ordering) | |||
| default List<String> getRegions(Map<String, Object> context) { | |||
| String region = (String) context.getOrDefault("region", null); | |||
| Object region = context.getOrDefault("region", null); | |||
There was a problem hiding this comment.
this sometimes is a string and sometimes a list. I tried to make it handle both. but also wrapped in try/catch in the other files
marchello2000
commented
Aug 6, 2020
| @@ -169,7 +170,7 @@ class RunTaskHandler( | |||
| } else if (e is TimeoutException && stage.context["markSuccessfulOnTimeout"] == true) { | |||
| queue.push(CompleteTask(message, SUCCEEDED)) | |||
| } else { | |||
| if (e !is TimeoutException) { | |||
| if (e !is TimeoutException && e !is UserException) { | |||
There was a problem hiding this comment.
oh, this is actually from a related but separate change. but might as well go together. Basically, we shouldn't log errors for exceptiosn that are not in "our" control. E.g. bad SpEL expression and any other UserExceptions
cfieber
approved these changes
Aug 6, 2020
KathrynLewis
pushed a commit
to KathrynLewis/orca
that referenced
this pull request
Jan 31, 2021
…r#3843) It's possible for trackResult metrics call to fail and we don't want that failure to leak out and fail orca tasks Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for trackResult metrics call to fail and we don't want that failure to leak out and fail orca tasks